Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging operator update #574

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Logging operator update #574

merged 4 commits into from
Jun 19, 2023

Conversation

smlx
Copy link
Member

@smlx smlx commented Jun 2, 2023

This PR updates the logging operator, which is the underlying log collection system of the lagoon-logging chart.

Importantly, this update requires some manual CRD updates to be applied after the chart is upgraded, if upgrading from an earlier version of lagoon-logging:

helm repo add kube-logging https://kube-logging.github.io/helm-charts
helm show crds kube-logging/logging-operator --version 4.2.3 | kubectl apply --server-side --force-conflicts -f -

I'll also add the instructions above to the release notes.

@smlx smlx force-pushed the logging-operator-update branch from 47c289e to 639d065 Compare June 2, 2023 06:30
@smlx smlx marked this pull request as ready for review June 2, 2023 06:48
@smlx smlx requested a review from tobybellwood June 2, 2023 06:48
@tobybellwood
Copy link
Member

tobybellwood commented Jun 2, 2023

worth noting for the record that this is a neater way to install those CRDs

helm show crds kube-logging/logging-operator --version 4.2.3 | kubectl apply -f -

@smlx
Copy link
Member Author

smlx commented Jun 2, 2023

TIL thanks!

@smlx smlx force-pushed the logging-operator-update branch 2 times, most recently from 8c8a8c1 to 83843dd Compare June 9, 2023 01:43
@smlx smlx marked this pull request as draft June 9, 2023 02:04
@smlx smlx force-pushed the logging-operator-update branch from c93225f to afeb596 Compare June 9, 2023 07:36
@smlx smlx marked this pull request as ready for review June 9, 2023 07:44
smlx added 4 commits June 16, 2023 21:09
kube-logging has moved to a new repository.
This flag causes e.g. daemonsets and statefulsets to be forcefully
deleted and recreated if required for a configuration change.

Unfortunately this can mean transient data loss (e.g. data in buffers),
but that seems to be a reasonable tradeoff.
@smlx
Copy link
Member Author

smlx commented Jun 19, 2023

hi @tobybellwood any problem with merging this?

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - happy to merge

@smlx smlx merged commit c0f9c54 into main Jun 19, 2023
@smlx smlx deleted the logging-operator-update branch June 19, 2023 04:29
@tobybellwood
Copy link
Member

Worth noting here that in the upgrade process if you encounter an error with PSP

Error: UPGRADE FAILED: unable to build kubernetes objects from current release manifest: resource mapping not found for name: "psp.logging-operator" namespace: "lagoon-logging" from "": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"

You should use the mapkubeapis helm plugin to remove the PSP from the helm cache

helm mapkubeapis lagoon-logging --namespace lagoon-logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants